Comments on: Using short if statement in programming

By: Adam

Adam — Tue, 14 Oct 2008 19:11:09 +0000

Thanks to everyone for the great feedback! I have made changes to the ternary operator example to remove the unnecessary echo statements.

By: mysql

mysql — Fri, 10 Oct 2008 12:05:26 +0000

You also move “echo” function out of statment:

echo $nFoo > 0 ? “I’m at the work.” : “I’m at home.”;

I personaly add braces when using this type of statment to make it more readable:

echo (($nFoo > 0) ? “I’m at the work.” : “I’m at home.”);

By: hartmut

hartmut — Thu, 09 Oct 2008 12:14:06 +0000

A better example would have been

echo ($nFoo > 0) ? “I’m at the work.” : “I’m at home.”;

as one of the main differences between an if block and a ternary (besides the amount of keystrokes needed) is that the ternary is an expression and so has a result value.

IMHO it is also good style to put ternary parts on different lines unless they are *really* short like “$leap_year ? 29 : 28″:

echo ($nFoo > 0)
? “I’m at the work.”
: “I’m at home.”;

By: LGB

LGB — Thu, 09 Oct 2008 09:54:10 +0000

$nFoo > 0 ? echo “I’m at the work.” : echo “I’m at home.”;

This is the overcomplicated version, still. You can use this:

echo $nFoo > 0 ? “I’m at the work.” : “I’m at home.”;

Or even:

echo “I’m at “.($nFoo > 0 ? “the work”:”home”);

By: Thomas CORBIERE

Thomas CORBIERE — Thu, 09 Oct 2008 06:53:17 +0000

This example doesn’t work as echo is not an expression and the ternary operator expects his arguments to be expressions. The correct example should be :

echo $nFoo > 0 ? “I’m at the work.” : “I’m at home.” ;

By: Jeremy Peterson

Jeremy Peterson — Thu, 09 Oct 2008 01:35:11 +0000

I used to hate the ternary operator, because it puts two possible values for a variable on one line and I’d like to keep my style for if/else statements consistent.

It is much easier to put these lines of code on one line than taking up six lines of code. Not only is it a matter of space, but for simple variable definitions it makes it easy to have a default value.

Ex:
$page_num = ($_REQUEST['page']) ? $_REQUEST['page'] : 1;// Default 1st page.

Jeremy

By: Rob Wultsch

Rob Wultsch — Thu, 09 Oct 2008 01:29:34 +0000

I have seen some horrific uses of the ternary operator. I would rather it not be used than abused.

Something I wrote on the topic:
http://wultsch.com/blog/2008/08/17/why-php-sucks/

By: K Jordan

K Jordan — Thu, 09 Oct 2008 01:21:39 +0000

Especially since PHP does it backwards with regards to that if you have nested ternary operators.

You could also eliminate it down to one echo and just have it evaluate which string to echo out.

By: Johannes

Johannes — Wed, 08 Oct 2008 23:47:15 +0000

Your second example won’t work, echo can’t be used inside an expression, youd have to use print (that’s the only difference between the two btw., print always returns true and vcan be used in expressions, echo can’t) or you have to write the echo outside the ternary, which i consider nicer.

echo $condition ? “yes” : “no”;

But don’t abuse ternaries, I saw people widely nesting them – unreadable that is

By: JulesBravo

JulesBravo — Wed, 08 Oct 2008 22:58:48 +0000

echo ( $nFoo > 0 ? “I’m at the work.” : “I’m at home.” );

I think that’s better syntax.

By: Bill Karwin

Bill Karwin — Wed, 08 Oct 2008 22:32:14 +0000

One drawback to using the ternary operator is that you now have a logic branch in a single “line” of code. This makes it hard to measure code coverage from tests, for example. It also makes diffs less clear when you commit code changes to source control.

I never use the ternary operator when each predicate is a full statement of code. I use the ternary operator only when I need each predicate to return a value because the whole expression returns a value.

As soon as you need either predicate to be two statements, you must rewrite the expression into a full if/then/else construct anyway.

It should not be your goal to write code that has fewer lines. It should be your goal to write code that is easier to test, easier to change, easier to document, easier to maintain.

By: Joe Izenman

Joe Izenman — Wed, 08 Oct 2008 22:27:08 +0000

In PHP you can also pull those echo statements out and have the ternary statement just return a string to a single echo, for incrementally cleaner code:

echo $nFoo > 0 ? “I’m at the work.” : “I’m at home.”;